-
Notifications
You must be signed in to change notification settings - Fork 23
[tritonbench] Benchmarking without docker with single CPU thread #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
huydhn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Just FYI, with the docker-in-docker setup for multi-tenancy, here is the env the CI is using without using a Docker image https://github.com/meta-pytorch/pytorch-gha-infra/blob/main/multi-tenant/images/multi-tenant-gpu/Dockerfile |
|
Yeah we met a few issues with dind on AMD, plus it seems |
On AMD, we observed high variance when benchmarking in dind: meta-pytorch/tritonbench#726
On NVIDIA B200 runner, we observed high variance when benchmarking with multiple CPU cores: #130
We are pinning the job to single CPU thread to stabilize the benchmark result.
Test plan:
https://github.com/pytorch/pytorch-integration-testing/actions/runs/20983664412